Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial checkin of the monorepo structure + sw-appcache-behavior #1

Merged
merged 1 commit into from
May 16, 2016

Conversation

jeffposnick
Copy link
Contributor

R: @addyosmani @gauntface @wibblymat
CC: @jakearchibald @jpmedley

Here's a (very large—sorry!) code dump of where I currently stand with the monorepo infrastructure + the first project, sw-appcache-behavior. There are some things that are still a work-in-progress, but it's far enough along to start breaking up additions into follow-up PRs.

Monorepo Implementation Status

  • Build tasks.
  • Test tasks.
  • Linting tasks.
  • NOT FINISHED Automatic documentation generation.
  • NOT FINISHED Automatic npm publishing.

sw-appcache-behavior Status

  • Functionality appears to be good.
  • Initial set of end-to-end tests of caching behavior all pass.
  • Basic samples.
  • NOT FINISHED Additional end-to-end tests.
  • NOT FINISHED Documentation.

The sw-appcache-behavior code was reviewed in jeffposnick/appcache2serviceworker#1

import path from 'path';
import promisify from 'promisify-node';

export let globPromise = promisify('glob');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this is a style thing, and we have time constraints, I wouldn't block this but I'm opening a separate issue to discuss naming conventions. #2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@wibblymat
Copy link

I have ignored the stuff in projects/sw-appcache-behavior/ because it was reviewed elsewhere.

If that's a correct assumption then LGTM.

@@ -0,0 +1,9 @@
{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #5

@jeffposnick
Copy link
Contributor Author

Merging, and will put together some follow-up PRs to resolve repo issues not addressed in this PR.

@mattiaswelander
Copy link

Hi, I am not familiar with how service workers work, I have an application that uses appcache. Is this the right tool to convert my current application to use service workers instead? Is there any how-to site or document or am I just expected to drill through your code and also to learn everything about service workers before I can get started? Very new to this side of things.

@gauntface
Copy link

@mattiaswelander please raise questions here: https://github.com/GoogleChrome/sw-appcache-behavior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants